fix: borders on fullscreen Reviewer

[david-allison]

When going fullscreen, the reviewer had white/blue borders rather than
filling the content

Cause:

d0d1edd moved to a single xml file for
the navigation drawer, rather than copy/pasting it into each file

Some layouts excluded android:fitsSystemWindows="true", but the new
xml file always included this.

This caused the layout problems

Fixes

Fixes #9267

Approach

• add method: fitsSystemWindows and layout without the variable

How Has This Been Tested?

My Android 11

Learning (optional, can help others)

• I wasted a lot of time learning about PhoneWindow on Android Code Search

Checklist

• You have not changed whitespace unnecessarily (it makes diffs hard to read)
• You have a descriptive commit message with a short title (first line, max 50 chars).
• Your code follows the style of the project (e.g. never omit braces in if statements)
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[mikehardy]

One wish for a strongly typed set of layout ints, but really that's a wish as it's clearly not a regression, just that you might know them off-hand at this point and know how to make the intdef or enum really quickly at this point.

If not, just hit the merge button - works for me

[david-allison]

Fair comment - I was considering it anyway, held off as the only other usage was directly above

[david-allison]

More work than I thought, but it caught a bug (not in this code), so all worth it

[mikehardy]

Will this fix #9279 as well? it might...

[david-allison]

No it doesn't, there's something else going on there.

Force pushed & updated code

[mikehardy]

unit test fail is legit - looks like a symbol mixup during re-shape-basing

[mikehardy]

Wow, our full screen mode proliferation is kind of crazy.
This is now a real advance in the state of things I think, the reshape is a significant positive step to me
...and you got a bug :-)