Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ktlint): bump ktlint to 0.45.1 / spacing changes w/new version #10608

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

mikehardy
Copy link
Member

Pull Request template

Purpose / Description

Bump underlying version of ktlint in order to access this memory fix: pinterest/ktlint#1216

Fixes

Fixes #10242 (well, should fix it for real, can reopen I guess, if not)

Approach

spacing changes were produced automatically using the new version on the
command line with -F argument to auto-fix spacing to conform with new
version of the tool.

It has to be changed at same time as the version since ktlint actually changed it's behavior

How Has This Been Tested?

I ran ktlint a few times from the command line and it seemed fine?

I verified via ./gradlew :AnkiDroid:dependencies |grep ktlint that it was pullingn 0.42.1 before this change and is getting 0.45.1 now.

Learning (optional, can help others)

Allowing version overrides on transitive dependencies is really helpful if you make things transitively dependent on consumers of your project. Thanks gradle ktlint plugin :-)

Checklist

Please, go through these checks before submitting the PR.

  • You have not changed whitespace unnecessarily (it makes diffs hard to read)
  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • Your code follows the style of the project (e.g. never omit braces in if statements)
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spacing changes were produced automatically using the new version on the
command line with `-F` argument to auto-fix spacing to conform with new
version of the tool
@david-allison david-allison added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Review labels Mar 23, 2022
@mikehardy
Copy link
Member Author

Forgot the lint-rules build.gradle! Got it with a second push, same commit. My dependencies check was AnkiDroid specific so missed lint-rules module first time.

@mikehardy mikehardy merged commit 2147589 into ankidroid:main Mar 23, 2022
@mikehardy mikehardy deleted the ktlint-0.45.1 branch March 23, 2022 21:14
@mikehardy mikehardy removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java Heap Space Error Memory leak in ktlint when used in gradle plugins
2 participants