Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC] Filter Sheet: Create function to retrieve names of all models #11712

Merged
merged 1 commit into from Jun 27, 2022

Conversation

viciousAegis
Copy link
Member

Pull Request template

Purpose / Description

Create a function to return the names of all the note models being used

Fixes

Fixes Link to the issues.

Approach

Create a new function to return a list of names of all the models

How Has This Been Tested?

TODO
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration (SDK version(s), emulator or physical, etc)

Learning (optional, can help others)

Describe the research stage

Links to blog posts, patterns, libraries or addons used to solve this problem

Checklist

Please, go through these checks before submitting the PR.

  • You have not changed whitespace unnecessarily (it makes diffs hard to read)
  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • Your code follows the style of the project (e.g. never omit braces in if statements)
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@viciousAegis viciousAegis added the Review High Priority Request for high priority review label Jun 27, 2022
@viciousAegis
Copy link
Member Author

@ankidroid/gsoc-mentor allNames() function ready for review

@david-allison david-allison added the Needs Second Approval Has one approval, one more approval to merge label Jun 27, 2022
@krmanik krmanik added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jun 27, 2022
@krmanik krmanik merged commit 348fbcc into ankidroid:main Jun 27, 2022
@github-actions github-actions bot added this to the 2.16 release milestone Jun 27, 2022
@github-actions github-actions bot removed Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) Review High Priority Request for high priority review labels Jun 27, 2022
@viciousAegis viciousAegis deleted the modelFunc branch June 27, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants