test: fix OutOfMemoryError: Java heap space #15532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on macos:
```
at com.ichi2.anki.dialogs.CreateDeckDialogTest.setUp(CreateDeckDialogTest.kt:52)
Caused by:
java.lang.OutOfMemoryError: Java heap space
at java.desktop/java.awt.image.DataBufferInt.<init>(DataBufferInt.java:77)
at java.desktop/java.awt.image.Raster.createPackedRaster(Raster.java:538)
at java.desktop/java.awt.image.DirectColorModel.createCompatibleWritableRaster(DirectColorModel.java:1032)
at java.desktop/java.awt.image.BufferedImage.<init>(BufferedImage.java:333)
at org.robolectric.shadows.ShadowBitmapFactory.create(ShadowBitmapFactory.java:287)
at org.robolectric.shadows.ShadowBitmapFactory.decodeStream(ShadowBitmapFactory.java:189)
at org.robolectric.shadows.ShadowBitmapFactory.decodeStream(ShadowBitmapFactory.java:153)
```
https://redirect.github.com/ankidroid/Anki-Android/pull/15520#issuecomment-1948416566
5 tasks
david-allison
added
the
Pending Merge
github-actions
bot
removed
the
Pending Merge
mikehardy
reviewed
Feb 16, 2024
| @@ -30,6 +30,7 @@ import com.ichi2.anki.dialogs.CreateDeckDialog.DeckDialogType | |||
| import com.ichi2.anki.dialogs.utils.input | |||
| import com.ichi2.libanki.DeckId | |||
| import com.ichi2.utils.positiveButton | |||
| import okhttp3.internal.closeQuietly | |||
There was a problem hiding this comment.
is this correct? an internal import, but the method call below is on the activityScenario member
There was a problem hiding this comment.
It's an extension to closeable which ignores checked exceptions
There was a problem hiding this comment.
/** Closes this, ignoring any checked exceptions. */
fun Closeable.closeQuietly() {
try {
close()
} catch (rethrown: RuntimeException) {
throw rethrown
} catch (_: Exception) {
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on macos: