feat(check-pronunciation): Streamline UX

[david-allison]

Purpose / Description

A few issues/suggestions were raised in #16185 about the audio recorder changes introduced for #13043

• takes up too much space vertically
• increased number of touches required
• ❓ stops working after a while
• ❌ move the recorder to the bottom of the screen
• ✅ A long-press should start, releasing the long-press should stop

Fixes

• Fixes Simplify "Pronunciation Check" feature for Reviewer #16185

Approach

1. Major refactor to improve the state handling logic
2. Simplify the Reviewer state to the following, add a new layout and changes to the Waveform control:

stateDiagram-v2
    direction LR
    [*] --> Empty

    Empty --> Recording : ⏺️
    Recording --> Empty : ❎
    Recording --> Playback : ⏹️
    Playback --> Empty : ❎

    state Playback {
        [*]  --> p1
        p1: Paused
        p2: Playing

        p1 --> p2 : ▶️
        p2 --> p1 : ↩️
    }

3. Add 'on hold' logic for long presses

How Has This Been Tested?

Screen_Recording_20240422_184951_AnkiDroid.mp4

Learning (optional, can help others)

• onStop
• Adding custom attributes to Views
• MaterialButton is hard when it comes to centering icons

Checklist

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner
  • ⚠️ no issues with touch targets. Historical issues with 'item label' - proposing to extract to another issue

[criticalAY]

Nice!! Especially the AudioRecorderController, using enum 👍 , Looks good to me!!

[mikehardy]

always daunting to see "large diffs hidden by default" type message in the commit viewer but ... all looks good, much more readable style with the enum state handling

[david-allison]

Blocked on #16248 (comment)