Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated strings from Crowdin 2024/04/26 19:01 #16278

Merged
merged 1 commit into from Apr 27, 2024
Merged

Updated strings from Crowdin 2024/04/26 19:01 #16278

merged 1 commit into from Apr 27, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Contains the newest strings changes from Crowdin.

https://crowdin.com/project/ankidroid/activity-stream

@david-allison david-allison mentioned this pull request Apr 26, 2024
Merged
5 tasks
david-allison
david-allison requested changes Apr 26, 2024
View reviewed changes
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... I didn't change the key, and yet a full retranslation was requested?

AnkiDroid/src/main/res/values-ar/02-strings.xml Outdated Show resolved Hide resolved
AnkiDroid/src/main/res/values-ar/03-dialogs.xml Outdated Show resolved Hide resolved
AnkiDroid/src/main/res/values-be/02-strings.xml Show resolved Hide resolved
AnkiDroid/src/main/res/values-bg/03-dialogs.xml Show resolved Hide resolved
AnkiDroid/src/main/res/values-bn/02-strings.xml Show resolved Hide resolved
AnkiDroid/src/main/res/values-eo/03-dialogs.xml Show resolved Hide resolved
AnkiDroid/src/main/res/values-es-rAR/02-strings.xml Show resolved Hide resolved
AnkiDroid/src/main/res/values-es-rAR/03-dialogs.xml Show resolved Hide resolved
AnkiDroid/src/main/res/values-es-rES/02-strings.xml Show resolved Hide resolved
AnkiDroid/src/main/res/values-es-rES/03-dialogs.xml Show resolved Hide resolved
david-allison
david-allison reviewed Apr 26, 2024
View reviewed changes
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a number more to go

AnkiDroid/src/main/res/values-et/02-strings.xml Show resolved Hide resolved
AnkiDroid/src/main/res/values-fa/02-strings.xml Outdated Show resolved Hide resolved
AnkiDroid/src/main/res/values-fa/03-dialogs.xml Outdated Show resolved Hide resolved
AnkiDroid/src/main/res/values-fi/02-strings.xml Show resolved Hide resolved
AnkiDroid/src/main/res/values-fil/02-strings.xml Show resolved Hide resolved
AnkiDroid/src/main/res/values-pl/03-dialogs.xml Show resolved Hide resolved
AnkiDroid/src/main/res/values-pt-rBR/02-strings.xml Show resolved Hide resolved
AnkiDroid/src/main/res/values-pt-rBR/03-dialogs.xml Show resolved Hide resolved
AnkiDroid/src/main/res/values-pt-rPT/02-strings.xml Show resolved Hide resolved
AnkiDroid/src/main/res/values-pt-rPT/03-dialogs.xml Show resolved Hide resolved
@david-allison david-allison self-assigned this Apr 26, 2024
david-allison
david-allison reviewed Apr 26, 2024
View reviewed changes
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

export_send_no_handlers done

dialog_processing - remaining (likely before pl)

AnkiDroid/src/main/res/values-ar/02-strings.xml Outdated Show resolved Hide resolved
AnkiDroid/src/main/res/values-zh-rTW/03-dialogs.xml Outdated Show resolved Hide resolved
AnkiDroid/src/main/res/values-zh-rTW/02-strings.xml Outdated Show resolved Hide resolved
AnkiDroid/src/main/res/values-zh-rCN/03-dialogs.xml Show resolved Hide resolved
AnkiDroid/src/main/res/values-zh-rCN/02-strings.xml Show resolved Hide resolved
AnkiDroid/src/main/res/values-tr/03-dialogs.xml Show resolved Hide resolved
AnkiDroid/src/main/res/values-tt/02-strings.xml Show resolved Hide resolved
AnkiDroid/src/main/res/values-uk/02-strings.xml Show resolved Hide resolved
AnkiDroid/src/main/res/values-uk/03-dialogs.xml Outdated Show resolved Hide resolved
AnkiDroid/src/main/res/values-ur/02-strings.xml Outdated Show resolved Hide resolved
@github-actions github-actions bot force-pushed the i18n_sync branch 3 times, most recently from eabcdf3 to 66db150 Compare April 26, 2024 21:32
david-allison
david-allison requested changes Apr 26, 2024
View reviewed changes
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last one

AnkiDroid/src/main/res/values-ar/10-preferences.xml Outdated Show resolved Hide resolved
AnkiDroid/src/main/res/values-fa/01-core.xml Outdated Show resolved Hide resolved
AnkiDroid/src/main/res/values-fa/02-strings.xml Outdated Show resolved Hide resolved
AnkiDroid/src/main/res/values-fa/09-backup.xml Outdated Show resolved Hide resolved
AnkiDroid/src/main/res/values-fa/10-preferences.xml Outdated Show resolved Hide resolved
AnkiDroid/src/main/res/values-heb/03-dialogs.xml Outdated Show resolved Hide resolved
AnkiDroid/src/main/res/values-heb/05-feedback.xml Outdated Show resolved Hide resolved
AnkiDroid/src/main/res/values-heb/10-preferences.xml Outdated Show resolved Hide resolved
AnkiDroid/src/main/res/values-kn/04-network.xml Outdated Show resolved Hide resolved
AnkiDroid/src/main/res/values-ur/02-strings.xml Outdated Show resolved Hide resolved
david-allison
david-allison approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One for reviewer 2, the rest seem great

@david-allison david-allison reopened this Apr 26, 2024
@david-allison david-allison removed their assignment Apr 26, 2024
@david-allison david-allison added the Review High Priority Request for high priority review label Apr 26, 2024
mikehardy
mikehardy approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm about out of time for the day so this is a provisional approval based on the hope that the sync I just did pulls down the translation I just did for Persian/Farsi and it resolves that one ?

Nice to see repeated syncs on i18n_sync branch pre-merge not show failure anymore!

@mikehardy mikehardy closed this Apr 26, 2024
@mikehardy mikehardy reopened this Apr 26, 2024
@mikehardy mikehardy added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Review High Priority Request for high priority review labels Apr 26, 2024
@david-allison
Copy link
Member

david-allison commented Apr 27, 2024 •
edited

The issue with Persian/Farsi is that I initially want to ignore the ... transformation for RTL languages (ar, fa, heb, ckb, ur), so there should be no changes in the diffs

Even if it's correct, the following screenshot looks wrong (trailing semicolon), and I don't want to waste reviewer time here, or risk breakages

Screenshot 2024-04-27 at 01 00 20

@david-allison david-allison added the Needs reviewer reply Waiting for a reply from another reviewer label Apr 27, 2024
@david-allison
Copy link
Member

david-allison commented Apr 27, 2024 •
edited

I'm off for today, I hope my last CrowdIn change fixes it so there's no diff. 30 mins to wait

@david-allison david-allison reopened this Apr 27, 2024
david-allison
david-allison approved these changes Apr 27, 2024
View reviewed changes
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I no longer see values-fa, this seems good to me

@david-allison
Copy link
Member

@mikehardy pending final approval

mikehardy
mikehardy approved these changes Apr 27, 2024
View reviewed changes
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epic

@mikehardy mikehardy added this pull request to the merge queue Apr 27, 2024
Merged via the queue into main with commit 70aaa83 Apr 27, 2024
13 checks passed
@github-actions github-actions bot added this to the 2.18 release milestone Apr 27, 2024
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Apr 27, 2024
@mikehardy mikehardy mentioned this pull request Apr 27, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

@david-allison david-allison david-allison approved these changes

Assignees
No one assigned
Labels
Needs reviewer reply Waiting for a reply from another reviewer
Projects
None yet
Milestone
2.18 release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@david-allison @mikehardy