Show a media check option on failed media sync #3816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only required for Android 2.2 and below which is now unsupported.
|
After giving it some thought, I realise that the most likely culprit for the 0-byte files is the multimedia editor. There is also a possibility that the importer is doing it but I feel it's less likely. This commit will save exception reports when the exception is triggered so we should be able to see the file names in the logcat output (I hope) which might give us a clue about what is causing it. |
timrae
added a commit
that referenced
this pull request
Nov 7, 2015
Show a media check option on failed media sync
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3782.
The first commit removes some no longer required exception handling. The second commit shows a dialog with a "check media" button for any media sync attempts rejected by the server (0 byte files are one of them).
I didn't feel like snackbars were good for this since all our sync errors have a persisting error dialog, and this one requires user action on top of that.