Refactoring of statistics #4114
Conversation
|
Does this fix any bugs or just pure refactoring? What's the reason / motivation for the changes? |
|
It is pure refactoring. The motivatation is make the code more readable. It is my first attempt for commit to open source project, next time I will try bug fixing or implementing of the new feature :) |
| } | ||
| mAxisTitles = new int[] { type.ordinal(), R.string.stats_answers, R.string.stats_cumulative_answers }; | ||
| } else if(charType == ChartType.REVIEW_TIME) | ||
| { |
There was a problem hiding this comment.
Make sure this opening brace { is on the same line as the beginning of the block to remain consistent with the rest of the codebase. Also, the indenting of this block is off.
|
Everything looks fine here. Just one minor nitpick for you to fix up. Once you've fixed it, you can amend the commit and force push the branch and it'll show up here.
Refactoring code is always a great way to familiarize yourself with the codebase. Don't feel compelled to rush into adding new features or anything if you're comfortable with doing just this for a while. Thanks for taking the time to help us improve AnkiDroid! |
|
I fixed it. But the tests failed. I tried to start the tests on my local machine and they passed. I am not sure what was wrong. |
|
Travis is going crazy lately, failing for no reason. Don't worry about it. Can you please squash your commits though: |
Only formating of the one if block
|
Squashing is done. |
|
In the future, if you are only making a small change to an existing commit, you can simply amend the previous one instead of committing on top of it: This will save you from having to squash it down later on. |
I've read the code of computing statistics. There is int variable called mType which can have only three values. I decided to create enum called AxisType and replace type of mType.
There is method calculateDone in Stats.java. Second method variable is boolean. The function of boolean is not described in javadoc. I decided replace boolean by Chartype and make the method private. Then two public methods will be created: calculateReviewCount and calculateReviewTime. This two new methods will use method calculateDone.