Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoteEditor: Stop replacing newlines with "<br>" #6417

Conversation

david-allison
Copy link
Member

Review Goals

  • Determine if there are any cases where we want to perform this operation (checksum, duplicates)?

Purpose / Description

To my knowledge, Anki Desktop does not do this, and it causes various bugs

Fixes

Fixes #4189
Fixes #3304

Approach

Remove the offending code

How Has This Been Tested?

Checklist

  • You have not changed whitespace unnecessarily (it makes diffs hard to read)
  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • Your code follows the style of the project (e.g. never omit braces in if statements)
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code

To my knowledge, Anki Desktop does not do this, and it causes various bugs
@david-allison
Copy link
Member Author

Okay... back to the drawing board. We need an end-to-end test to ensure that newlines are replaced in the CardViewer.

aa
bb
gg

is now rendered as aa bb gg

@david-allison david-allison marked this pull request as draft June 9, 2020 15:01
@david-allison
Copy link
Member Author

I don't think this is going to get resolved before the Visual Editor comes along. Let's not clutter up the PRs

@david-allison david-allison deleted the 3304-stop-munging-newlines branch June 13, 2020 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant