Increase defensiveness #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took every usage of the API and add defensive checks of return values, and tried to behave appropriately depending on the context if we got an error from the API
This should help with ankidroid/Anki-Android#4617 as I think API consumers were just copy-pasting code from the sample app (like normal people would) and thus their apps were crashing if the API didn't work as expected
I also discovered how to finally expose the source of the deprecation warnings I was getting from the compiler, and de-linted that as a separate commit (it was just a deprecated abstract method we have to override to be concrete, unavoidable)