Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@font-face injection stopped working due to "!important" #559

Closed
kojiishi opened this issue Jul 29, 2020 · 2 comments
Closed

@font-face injection stopped working due to "!important" #559

kojiishi opened this issue Jul 29, 2020 · 2 comments
Labels
bug Bug report resolved

Comments

@kojiishi
Copy link

kojiishi commented Jul 29, 2020

I've been injecting:

@font-face {
  font-family: 'MS PGothic';
  src: local('Meiryo');
}

to replace old fonts to more modern ones. This used to work, but stopped working recently. When I inspect the page:

<style type="text/css" id="stylebot-css-zai.diamond.jp">@font-face {
  font-family: 'MS PGothic' !important;
  src: local('Meiryo') !important;
}
</style>

and this !important seems to be the cause. Is this a recent change? Is there a way to not to add this?

@ankit ankit added bug Bug report fix in progress Prioritized and actively working on fixing this bug labels Jul 29, 2020
@ankit
Copy link
Owner

ankit commented Jul 29, 2020

@kojiishi Thanks for reporting this issue. Yes, this should be easy to fix. I will roll out a bugfix soon.

@ankit ankit added in webstore review Release containing fix is in review in Chrome Web Store resolved and removed fix in progress Prioritized and actively working on fixing this bug in webstore review Release containing fix is in review in Chrome Web Store labels Jul 30, 2020
@ankit ankit closed this as completed Jul 31, 2020
@kojiishi
Copy link
Author

kojiishi commented Aug 7, 2020

Thank you for the prompt fix, really appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report resolved
Projects
None yet
Development

No branches or pull requests

2 participants