Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styleTransform): add styleTransform opt #2

Merged
merged 8 commits into from
Mar 8, 2022

Conversation

thienphanexcalibur
Copy link

@thienphanexcalibur thienphanexcalibur commented Mar 8, 2022

There are some cases we need to fine tune the transformed style import.

I propose complementing the style opt as a function

style: (transformedPath: string) => string

Inspired from babel-plugin-import
https://www.npmjs.com/package/babel-plugin-import#style

@ankitchouhan1020
Copy link
Owner

Hi @thienphanexcalibur

Instead of creating a new option for this requirement, can we resuse the style option ?
style option currently accepts a boolean but it can be customized in a way that it accepts either a boolean or a function.

What's your thought on this ?

@thienphanexcalibur
Copy link
Author

@ankitchouhan1020 hey,
I think it's a great idea to reuse the style opt, have made the change. Please review and merge when you have time!

Thanks again for your awesome repo!

@ankitchouhan1020
Copy link
Owner

Great! LGTM 🚀

Thanks for your contribution @thienphanexcalibur 🙌

@ankitchouhan1020 ankitchouhan1020 merged commit c22e5e5 into ankitchouhan1020:main Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants