Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Svelte Editor Toolbar #1109

Merged
merged 97 commits into from Apr 16, 2021
Merged

Svelte Editor Toolbar #1109

merged 97 commits into from Apr 16, 2021

Commits on Apr 15, 2021

  1. Add ts/editor-toolbar

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    de77e40 View commit details
    Browse the repository at this point in the history

  2. First implementation

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    7787a78 View commit details
    Browse the repository at this point in the history

  3. Include icons directly in ts lib

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    a0a9619 View commit details
    Browse the repository at this point in the history

  4. Add remaining icons for toolbar

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    fee78d2 View commit details
    Browse the repository at this point in the history

  5. Add color.ts for foreground color and color picker

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    0963d53 View commit details
    Browse the repository at this point in the history

  6. Add CommandIconButton functionality

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    ccb7c5d View commit details
    Browse the repository at this point in the history

  7. Add ButtonGroup for grouping of toolbar items

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    9563da3 View commit details
    Browse the repository at this point in the history

  8. Display ButtonGroups inline-block

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    b26c429 View commit details
    Browse the repository at this point in the history

  9. Add hover and active effects

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    a12e39a View commit details
    Browse the repository at this point in the history

  10. Rename IconButtonInner to InnerButton, as it does not necessarily con… 

    …tain an Icon
    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    0269c97 View commit details
    Browse the repository at this point in the history

  11. Make all Leaf buttons 30px high and give same vertical-align

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    8c931af View commit details
    Browse the repository at this point in the history

  12. Merge buttons to one OuterButtonGroup 

    - keeping up the concept of left / right buttons might not be necessary anymore
- This might make it easier to display them on mobile, and simplifies the logic
    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    773f431 View commit details
    Browse the repository at this point in the history

  13. Simplify General Toolbar structure

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    bf433f1 View commit details
    Browse the repository at this point in the history

  14. Move initialization logic from EditorToolbar to index.ts

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    2f808fe View commit details
    Browse the repository at this point in the history

  15. Make all buttons functional

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    1202122 View commit details
    Browse the repository at this point in the history

  16. Make icons slightly smaller, so they are the same size as before

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    77de6c0 View commit details
    Browse the repository at this point in the history

  17. Add mathjaxButton and htmlButton instead of more button

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    b5b9c79 View commit details
    Browse the repository at this point in the history

  18. Add negative tabindex

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    7f5e9b1 View commit details
    Browse the repository at this point in the history

  19. Move display:flex from outer div to ButtonGroup ul

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    e25583d View commit details
    Browse the repository at this point in the history

  20. Add active shadow on ColorPicker

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    4280bf2 View commit details
    Browse the repository at this point in the history

  21. Display .active:active as :hover buttons

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    9340d20 View commit details
    Browse the repository at this point in the history

  22. Utilize enableButtons disableButtons from Svelte component

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    a820059 View commit details
    Browse the repository at this point in the history

  23. WIP: Turn DropdownMenu into a _decorator_ usable with all other butto… 

    …n types
    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    5eb07d3 View commit details
    Browse the repository at this point in the history

  24. Make it so you can include DropdownMenus on all kinds of buttons

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    391f64f View commit details
    Browse the repository at this point in the history

  25. Add dropdown menu to mathjax button

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    fa900e1 View commit details
    Browse the repository at this point in the history

  26. Add SelectButton

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    f526b51 View commit details
    Browse the repository at this point in the history

  27. Make Toolbar resizable through a single CSS variable --toolbar-size

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    fb668c5 View commit details
    Browse the repository at this point in the history

  28. Make select display inline-block

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    5f498e6 View commit details
    Browse the repository at this point in the history

  29. Give select an effect on :hover

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    9b68a5c View commit details
    Browse the repository at this point in the history

  30. Add first lazily loaded i18n strings

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    3ddbc1e View commit details
    Browse the repository at this point in the history

  31. Move logic from index.ts to their individual files

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    4e6d5d9 View commit details
    Browse the repository at this point in the history

  32. Add titles to buttons with lazyProperties

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    216b93c View commit details
    Browse the repository at this point in the history

  33. Add labels and titles to all buttons

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    7f42b38 View commit details
    Browse the repository at this point in the history

  34. Make it easier to update buttons and menus

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    45992b6 View commit details
    Browse the repository at this point in the history

  35. Add exports for add-ons

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    6953389 View commit details
    Browse the repository at this point in the history

  36. Add ButtonDropdown for dropdowns like the MathJax dropdown on AnkiMobile

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    9cbab08 View commit details
    Browse the repository at this point in the history

  37. Make --toolbar-size a parameter

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    8b90610 View commit details
    Browse the repository at this point in the history

  38. Pass in buttons and menus directly as stores

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    96feba7 View commit details
    Browse the repository at this point in the history

  39. Fix some code quality issues

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    37ed3e8 View commit details
    Browse the repository at this point in the history

  40. Remove lazyProperties -> we use withLazyProperties instead

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    10952de View commit details
    Browse the repository at this point in the history

  41. Support building as external repo

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    bb64f73 View commit details
    Browse the repository at this point in the history

  42. Fix clicking the bold button immediately showing the updated button s… 

    …tate

- rather than only after typing
    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    2046b00 View commit details
    Browse the repository at this point in the history

  43. Move enabled/disabled logic to EditorToolbar

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    2820167 View commit details
    Browse the repository at this point in the history

  44. Use dynamicComponent instead of withLazyProps

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    c7590c8 View commit details
    Browse the repository at this point in the history

  45. Change overflow of button groups to overflow-y auto 

    Avoids erratic creation of scrollbars
    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    120e145 View commit details
    Browse the repository at this point in the history

  46. Rename types.ts to types.d.ts

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    8e1092d View commit details
    Browse the repository at this point in the history

  47. Rename title to tooltip across editor toolbar components

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    a2d3720 View commit details
    Browse the repository at this point in the history

  48. Give clearer type names to dynamicComponent

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    bf33397 View commit details
    Browse the repository at this point in the history

  49. Make wraps a passable prop to EditorToolbar 

    Can be set to nowrap via document.getElementByID("editorToolbar").component.$set({ wraps: false })
    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    59884df View commit details
    Browse the repository at this point in the history

  50. Pass wraps more similiar to how size is passed via CSS variables

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    d3e1bfa View commit details
    Browse the repository at this point in the history

  51. Pass button groups as actual button groups, not arrays

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    86c57d5 View commit details
    Browse the repository at this point in the history

  52. Get rid of types.d.ts in favor of DynamicSvelteComponent

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    f88b9d6 View commit details
    Browse the repository at this point in the history

  53. Remove props property in favor of $$restProps

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    4c273ca View commit details
    Browse the repository at this point in the history

  54. Make buttons and button groups easily toggleable through hidden web c… 

    …omponent
    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    cbf72c0 View commit details
    Browse the repository at this point in the history

  55. Move cloze logic and wrapping logic editor-toolbar

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    fe4ba87 View commit details
    Browse the repository at this point in the history

  56. Show/Hide Cloze button depending on whether cloze type

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    eceb98f View commit details
    Browse the repository at this point in the history

  57. Fix sticky toolbar which was broken when introducing var(--toolbar-size)

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    8fd2166 View commit details
    Browse the repository at this point in the history

  58. Add a button / buttonGroup insertion API

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    d6ad508 View commit details
    Browse the repository at this point in the history

  59. Switch from lazy loading of properties to wrapping the buttons in a f… 

    …unction
    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    b364ae5 View commit details
    Browse the repository at this point in the history

  60. Introduce ToolbarItem as a better base type instead of DynamicSvelteC… 

    …omponent
    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    432e0a5 View commit details
    Browse the repository at this point in the history

  61. Add RawButton and hook old python hooks up to it

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    920b740 View commit details
    Browse the repository at this point in the history

  62. Remove $$restProps and make explicit dropdown support in buttons 

    * Currently LabelButton, CommandIconButtton, and IconButton support dropdowns
    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    1eafa7d View commit details
    Browse the repository at this point in the history

  63. Use compile_sass and add flag to make editor-toolbar compile again

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    38cc0df View commit details
    Browse the repository at this point in the history

  64. Include Dropdown directly from bootstrap, required installing popperjs

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    8f7c32f View commit details
    Browse the repository at this point in the history

  65. Also add Bootstrap buttons.scss

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    00d8d86 View commit details
    Browse the repository at this point in the history

  66. Add buttons_mixins.scss for sharing SCSS across components

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    443cef6 View commit details
    Browse the repository at this point in the history

  67. Make mdi also use renamed pkg_from_name

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    e6996ae View commit details
    Browse the repository at this point in the history

  68. Rely more heavily on bootstrap provided types for editor-toolbar

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    d6d4269 View commit details
    Browse the repository at this point in the history

  69. Correctly check for night mode

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    0133652 View commit details
    Browse the repository at this point in the history

  70. Switch from core to base CSS for editor view

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    9f740f3 View commit details
    Browse the repository at this point in the history

  71. Update CSS for ColorPicker and forecolor button

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    02c8893 View commit details
    Browse the repository at this point in the history

  72. Improve looks of color picker button

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    49daa2d View commit details
    Browse the repository at this point in the history

  73. Add theming support for DropdownItem and DropdownMenu

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    8760bd9 View commit details
    Browse the repository at this point in the history

  74. Give light mode effects on hover/active/focus as well

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    dd530dc View commit details
    Browse the repository at this point in the history

  75. Use padding for extended colorpicker background "border"

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    e732eca View commit details
    Browse the repository at this point in the history

  76. Add support for Preview button in Browser

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    a7d24e7 View commit details
    Browse the repository at this point in the history

  77. Style light mode button bar with borders 

    - whereas night mode toolbar has no visible borders
    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    b696635 View commit details
    Browse the repository at this point in the history

  78. Generalize ts/graphs/preferences to ts/sveltelib/preferences

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    13decbe View commit details
    Browse the repository at this point in the history

  79. Inline GraphData/GraphPreferences getters/setters into WithGraphData

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    e3a3ca3 View commit details
    Browse the repository at this point in the history

  80. Pass the svelte check for graphs

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    efc8678 View commit details
    Browse the repository at this point in the history

  81. Fix most of svelte-check issues for editor-toolbar

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    b0fab9c View commit details
    Browse the repository at this point in the history

  82. Make editor-toolbar pass eslint

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    60515f5 View commit details
    Browse the repository at this point in the history

  83. Explicitly name file in output_css for esbuild

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    5225ef3 View commit details
    Browse the repository at this point in the history

  84. Add shortcut labels for mathjax menu

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    58a85d8 View commit details
    Browse the repository at this point in the history

  85. Add Preview shortcut for browser

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    53ae03b View commit details
    Browse the repository at this point in the history

  86. Use new bootstrap dep

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    d07086d View commit details
    Browse the repository at this point in the history

  87. Use new bootstrap library paths

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    f9565cb View commit details
    Browse the repository at this point in the history

  88. Satisfy prettier

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    12c0a26 View commit details
    Browse the repository at this point in the history

  89. Add Latex formatting options to menu 

    *  Format shortcuts in monospace font and increase padding a little bit
    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    82f6e19 View commit details
    Browse the repository at this point in the history

  90. Pass svelte_check for editor-toolbar

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    449d285 View commit details
    Browse the repository at this point in the history

  91. Experimental: Add bootstrap to svelte_check dependencies

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    fb8a2f4 View commit details
    Browse the repository at this point in the history

  92. Add type to add_preview_shortcut

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    5702b3c View commit details
    Browse the repository at this point in the history

  93. Use bootstrap types for editor-toolbar svelte_check

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    bd4fe7c View commit details
    Browse the repository at this point in the history

  94. Add license headers

    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    b0885ef View commit details
    Browse the repository at this point in the history

  95. Make fields square again 

    This was an experiment, to adjust the field border-radius to the
buttons, but I think it looks cleaner if the fields are square
    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    304a7f2 View commit details
    Browse the repository at this point in the history

  96. Abandon btn-secondary and btn-light in favor our own definitions btn-… 

    …night and btn-day
    @hgiesel
    hgiesel committed Apr 15, 2021
    Copy the full SHA
    ccc48bd View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. Solve the race conditions of button insertion by operating on promise… 

    …s in EditorToolbar
    @hgiesel
    hgiesel committed Apr 16, 2021
    Copy the full SHA
    0f01e42 View commit details
    Browse the repository at this point in the history