Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniformly use properties to Button{Toolbar,Group} for setting button properties #1202

Merged
merged 2 commits into from
May 29, 2021

Conversation

hgiesel
Copy link
Contributor

@hgiesel hgiesel commented May 27, 2021

Instead of using WithTheming around ButtonToolbar/ButtonGroup.

Also fixes Deck options toolbar to pop into two lines, if the preset name is too long.

…roperties

Instead of using WithTheming around ButtonToolbar/ButtonGroup
@hgiesel hgiesel changed the title Uniformly use variables to Button{Toolbar,Group} for setting button properties Uniformly use properties to Button{Toolbar,Group} for setting button properties May 27, 2021
@dae
Copy link
Member

dae commented May 28, 2021

Not sure of the best place to put it, but we'll need an overflow-x somewhere, eg

diff --git a/ts/deckoptions/ConfigSelector.svelte b/ts/deckoptions/ConfigSelector.svelte
index 524717d49..2c10e994b 100644
--- a/ts/deckoptions/ConfigSelector.svelte
+++ b/ts/deckoptions/ConfigSelector.svelte
@@ -116,3 +116,9 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
         </ButtonToolbarItem>
     </ButtonToolbar>
 </StickyBar>
+
+<style>
+    :global(.btn-toolbar) {
+        overflow-x: hidden;
+    }
+</style>

Without it, the starting viewport is too big and it wraps anyway:

Screen Shot 2021-05-28 at 5 25 16 pm

Screen Shot 2021-05-28 at 5 25 06 pm

@dae
Copy link
Member

dae commented May 28, 2021

Hmm, the dropdown next to Save no longer seems to work for me either

@hgiesel
Copy link
Contributor Author

hgiesel commented May 28, 2021

Hmm, the dropdown next to Save no longer seems to work for me either

Cannot recreate this.

@hgiesel hgiesel mentioned this pull request May 29, 2021
2 tasks
@dae
Copy link
Member

dae commented May 29, 2021

Hmm, seems to work fine now. Thanks :-)

@dae dae merged commit bb2026f into ankitects:main May 29, 2021
@hgiesel hgiesel deleted the nowrapdeckoptionstoolbar branch October 20, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants