Fix toggle night mode in clayout #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once a QStyle different from the system default is applied, the system default palette can no longer be retrieved with standardPalette().
including the following changes: - rename "_getWindowColor" to "get_window_bg_color" to follow PEP8 - add "night_mode" argument to "get_window_bg_color" - make it possible to get the correct colors regardless of the current theme
required to emulate day mode in clayout if background-color is not set in .card styling
|
Sounds like a good approach - thanks Hikaru! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1166.
Regarding emulation of day mode (especially on non-Linux platforms):
Taking into account the possibility that the background color is not set in the
.cardstyling, I think we need to set the background color of the<body>element to theQPalette.Windowcolor value of the system default palette in order to emulate it correctly. However, on Windows (and probably on macOS as well), once thefusionQStyle is applied to enable night mode, the palette retrieved bystandardPalette()will be different from that in day mode.On Windows:
This is probably because the default QStyle on Windows and macOS is not
fusion. So in this PR, the system default palette is stored intheme_manager.default_palettebefore thefusionstyle is applied, so that theQPalette.Windowcolor value in day mode can be used in night mode on any platform.