Prevent webview from freezing due to error in _runHook

[hikaru-y]

Fixes https://forums.ankiweb.net/t/2-1-45-release-candidate/11362/20 .

I know that add-on authors and users should make sure that there are no errors in the hook functions, but I created this PR because the clayout's webview also freezes while editing a template.

[hgiesel]

This will start all promises sequentially, instead of running them in parallel. The catch should be on the Promise.all() call.

[hikaru-y]

@hgiesel Thanks for pointing that out.

The catch should be on the Promise.all() call.

This means something like the following?

--- a/ts/reviewer/index.ts
+++ b/ts/reviewer/index.ts
@@ -27,14 +27,14 @@ export function getTypedAnswer(): string | null {
     return typeans?.value ?? null;
 }

-function _runHook(arr: Array<Callback>): Promise<void[]> {
+function _runHook(arr: Array<Callback>): Promise<void[] | void> {
     const promises: (Promise<void> | void)[] = [];

     for (let i = 0; i < arr.length; i++) {
         promises.push(arr[i]());
     }

-    return Promise.all(promises);
+    return Promise.all(promises).catch((e) => console.error(e));
 }

 let _updatingQueue: Promise<void> = Promise.resolve();

I tried this, but it did not prevent the webview from freezing.

As you said, in this PR, hooks are executed sequentially. However, considering the case where there are multiple hooks that operate on the same DOM, I thought sequential execution would be more appropriate for this function than parallel execution, so that's what I did. I should have written the reason why I did it that way, though.

For example, if there are multiple hooks for manipulating images with querySelectorAll("img"), I think that parallel execution would not guarantee consistency of the results. Am I wrong?

---

Edit: If sequential execution is not appropriate, I will update the PR soon.

[hikaru-y]

Closed this PR. See #1302 (comment) .