Add forget card to review context "more" menu #1642
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope I did this correctly. Development notes say that there is a transition from python to rust for the business logic - forgetting cards seems like business logic...what I did in this PR is reference
forget_cards
fromscheduling.py
in the context menu:anki/qt/aqt/operations/scheduling.py
Lines 66 to 75 in 0c81bbc
Which looks like it eventually calls the rust backend?
anki/pylib/anki/scheduler/base.py
Lines 162 to 164 in 0c81bbc
Re: tests, it seemed like there were tests for
forget_cards
already, but didn't see anything specifically for the review view. I did check that clicking the menu and using the shortcut both work to forget a card. Let me know if that's not enough/expected.