Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #2518
This adds the
addons_manager_will_install_addon
andaddons_manager_did_install_addon
hooks. My main use case is to prevent update errors caused by the add-on holding a DB connection to some file in the add-on folder. Example usage:Another common source of installation errors are open .pyd files coming from bundled dependencies. The AnkiHub add-on for example patches
AddonManager.deleteAddon
twice to work around similar errors. (I probably have a bunch of more add-ons suffering from this issue too).dc066bb fixes a crash in .deleteAddon() when run from the update routine and OSError is thrown there.