Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-advance options to deck preset #2765

Merged
merged 16 commits into from Nov 13, 2023
Merged

Conversation

abdnh
Copy link
Contributor

@abdnh abdnh commented Oct 22, 2023

Closes #2645

@abdnh abdnh marked this pull request as draft October 22, 2023 10:08
@abdnh abdnh marked this pull request as ready for review October 24, 2023 17:42
Copy link
Member

@dae dae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Sorry, I forgot to mention one thing about how this should work: there should be a menu action that toggles auto-advance, so it doesn't happen until the user explicitly starts it. Its value shouldn't be saved, so it should always start off. The primary reason for this is that the congratulations page will switch back to review when the day rolls over, and users won't want to wake up to find all their cards have already been answered. :-)

timer = None

if conf["secondsToShowAnswer"]:
timer = self._show_answer_timer = self.mw.progress.timer(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason you didn't use single_shot() here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to compare the timers so that we make sure a previous card's timer doesn't get to execute on the next card.

@abdnh
Copy link
Contributor Author

abdnh commented Oct 25, 2023

users won't want to wake up to find all their cards have already been answered. :-)

That's a feature I'd love to use 😂

qt/aqt/reviewer.py Outdated Show resolved Hide resolved
@dae
Copy link
Member

dae commented Oct 26, 2023

Couple of remaining issues:

  • toggling auto-advance to on doesn't start it until you manually show answer
  • it remains on when you go back to the overview and then back into review
  • it might be nice if we automatically stop it when the user opens add/edit/browse

@dae
Copy link
Member

dae commented Oct 28, 2023

(in case it wasn't clear, I'm planning to skip over this for the 23.10 release, so there's no time pressure on this)

@dae
Copy link
Member

dae commented Nov 2, 2023

Thanks Abdo. I might need to hold off on this for a week or two, so we can get a hotfix update out first.

@dae dae merged commit ae7b14b into ankitects:main Nov 13, 2023
1 check passed
@abdnh abdnh deleted the auto-advance branch November 13, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add auto-advance options to deck preset
2 participants