Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tooltip strings for image occlusion center alignments #2815

Merged
merged 1 commit into from Nov 9, 2023

Conversation

snowtimeglass
Copy link
Contributor

The current tooltips probably don't match the icons respectively.
image
image

This commit will:

  • Fix the swapping of the following two tooltips: "Center Vertically" and "Center Horizontally".

  • Incidentally, add a name to CONTRIBUTORS

@dae
Copy link
Member

dae commented Nov 8, 2023

I think you're right; I got confused because I see 'vertically' and think the vertical bar should match. How about we use the wording Figma uses to make it a little clearer?

https://help.figma.com/hc/en-us/articles/360039956914-Adjust-alignment-rotation-and-position

@snowtimeglass
Copy link
Contributor Author

I got confused because I see 'vertically' and think the vertical bar should match.

Yes, I also feel the same confusion.

How about we use the wording Figma uses to make it a little clearer?

I agree with the idea. I also think the wording Figma uses is clearer.

Would you like me to change the following strings?

editing-image-occlusion-align-h-center = Center Horizontally

editing-image-occlusion-align-v-center = Center Vertically

@dae
Copy link
Member

dae commented Nov 9, 2023

Yes please.

@snowtimeglass snowtimeglass changed the title Fix swapped tooltips of image occlusion center alignments Change tooltip strings for image occlusion center alignments Nov 9, 2023
- Fix the swapping of the strings

- Change the strings to make the meanings clearer

- Incidentally, add a name to CONTRIBUTORS
@dae
Copy link
Member

dae commented Nov 9, 2023

Thank you!

@dae dae merged commit b3da6f1 into ankitects:main Nov 9, 2023
1 check passed
@snowtimeglass
Copy link
Contributor Author

Thank you, too!

@snowtimeglass snowtimeglass deleted the fix-swapped-tooltips branch November 9, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants