Show total review count when optimizing FSRS parameters #3027
Conversation
ftl/core/deck-config.ftl
Outdated
| *[other] { $pct }% of { $reviews } reviews | ||
| deck-config-percent-of-items = | ||
| { $count -> | ||
| [one] { $pct }% of { $count } item |
There was a problem hiding this comment.
Let's call them cards rather than items, because that's what they actually are. In hindsight, FSRSCard might have been a better name for them.
There was a problem hiding this comment.
No, ignore me. I always forget that we create multiple FSRSItems for a card.
There was a problem hiding this comment.
What exactly is an FSRS item, by the way? I think that it is better to document it somewhere because the users will begin asking it that after this is merged.
There was a problem hiding this comment.
This is how it's documented in fsrs-rs: https://github.com/open-spaced-repetition/fsrs-rs/blob/e34265a5de7a9fbb138ea8b600deae44cf05a129/src/dataset.rs#L16
|
Thanks Abdo. I agree that FSRS items is a bit of a vague term, and it might be nice to avoid exposing them to end-users. Could we just display the post-filtered review count instead? When optimizing the review count is returned by fsrs_items_for_training, and in the computing memory state case, only one fsrs item per card is returned, so it should be safe to tally the resulting reviews in the FSRS items. WDYT? |
|
Thanks, that's nicer :-) |
Closes #3000