Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Card %d for IO template names #3049

Merged
merged 1 commit into from Mar 6, 2024
Merged

Conversation

BrayanDSO
Copy link
Contributor

@BrayanDSO BrayanDSO commented Mar 3, 2024

@BrayanDSO BrayanDSO marked this pull request as draft March 4, 2024 01:01
@dae
Copy link
Member

dae commented Mar 4, 2024

My thinking in #3043 is that we'd use 'card x' for both I/O notetypes and normal clozes, so we don't need to check what type of card it is.

You should be able to fix the formatting issues with './ninja format'

@BrayanDSO
Copy link
Contributor Author

AFAIU, that box in the right of Options is only shown in Cloze types

'./ninja format'. I tried but it didn't work nor I got any error messages, and I ran out of time. I'll try to debug it later

@dae
Copy link
Member

dae commented Mar 5, 2024

I/O notetypes are cloze notetypes. Your code is showing something different for each of them; I'm suggesting we just use the same string in both cases.

@dae
Copy link
Member

dae commented Mar 5, 2024

You can use ./ninja check -v to see the commands that are run, and can run them manually if you want to see what they output.

@BrayanDSO
Copy link
Contributor Author

I/O notetypes are cloze notetypes. Your code is showing something different for each of them; I'm suggesting we just use the same string in both cases.

Got it. Sorry for the misunderstandement

You can use ./ninja check -v to see the commands that are run, and can run them manually if you want to see what they output.

Actually, I was just using Powershell instead of Bash. Fixed it now

@BrayanDSO BrayanDSO marked this pull request as ready for review March 5, 2024 13:52
@dae
Copy link
Member

dae commented Mar 6, 2024

No worries - thank you!

@dae dae merged commit d16131c into ankitects:main Mar 6, 2024
1 check passed
@abdnh
Copy link
Contributor

abdnh commented Mar 6, 2024

Actually, I was just using Powershell instead of Bash. Fixed it now

You can still use PowerShell if you have Bash on your path by the way.

@BrayanDSO BrayanDSO deleted the io_template_name branch March 14, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image Occlusion Cards... preview uses Cloze %d as the cards names
3 participants