Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore errors in do_window_cleanup to fix shutdown issue #3142

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

abdnh
Copy link
Contributor

@abdnh abdnh commented Apr 14, 2024

Closes #3126

I was able to reproduce it by changing time_to_wait too (and having auto sync enabled).

@voczi
Copy link
Contributor

voczi commented Apr 14, 2024

Figured out you could just do it like this:
if self._x_timer and not sip.isdeleted(self._x_timer):
Repeat for every timer in that method.

Docs for the single_shot method did also mention this.

@abdnh
Copy link
Contributor Author

abdnh commented Apr 14, 2024

Yes, I thought of that, but preferred to go for less code.

@dae
Copy link
Member

dae commented Apr 17, 2024

Great, thanks Abdo!

@dae dae merged commit 0a706c5 into ankitects:main Apr 17, 2024
1 check passed
@abdnh abdnh deleted the progress-cleanup-close branch April 17, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anki 24.04 does not close properly
3 participants