Add number truncation before back-end translation #3162
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3102
When the front-end
translate
is called, all numbers are truncated to 2 decimal places.The same was not true for the back-end
translate
, which seems to be the cause of this corner-case.It appears that the Rust implementation of Fluent doesn't automatically do the truncation (before the comparison to
[one]
in FTL) according to the FluentNumberOptions (maximum_fraction_digits
), while the JS version does. This is why my code explicitly rounds the number, where the TS only setsmaximumFractionDigits
.