Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test enhancement #1

Merged
merged 1 commit into from Nov 30, 2018
Merged

Test enhancement #1

merged 1 commit into from Nov 30, 2018

Conversation

peter279k
Copy link
Contributor

Changed log

  • Using DataProvider to collect test cases and split these from test method.
  • The assertSame arguments should be assertSame($expected, $actual).

Copy link
Owner

@ankitjain28may ankitjain28may left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :)

@ankitjain28may ankitjain28may merged commit d0cdbc5 into ankitjain28may:master Nov 30, 2018
@ankitjain28may
Copy link
Owner

Thanks for the contribution.

@peter279k peter279k deleted the test_enhancement branch November 30, 2018 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants