Some minor refactoring

ankitpokhrel · Dec 22, 2018 · c622799 · c622799
1 parent c4db35e
commit c622799
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/src/Cache/FileStore.php b/src/Cache/FileStore.php
@@ -90,7 +90,7 @@ protected function createCacheDir()
     }
 
     /**
-     * Create cache file and add required meta.
+     * Create a cache file.
      *
      * @return void
      */

diff --git a/src/File.php b/src/File.php
@@ -328,7 +328,7 @@ public function upload(int $totalBytes) : int
     }
 
     /**
-     * Open file in append binary mode.
+     * Open file in given mode.
      *
      * @param string $filePath
      * @param string $mode
@@ -374,6 +374,8 @@ public function exists(string $filePath, string $mode = self::READ_BINARY) : boo
     }
 
     /**
+     * Move file pointer to given offset.
+     *
      * @param Resource $handle
      * @param int      $offset
      * @param int      $whence
@@ -510,7 +512,7 @@ public function delete(array $files, bool $folder = false) : bool
     }
 
     /**
-     * Delete files.
+     * Delete multiple files.
      *
      * @param array $files
      *

diff --git a/src/Request.php b/src/Request.php
@@ -2,6 +2,7 @@
 
 namespace TusPhp;
 
+use TusPhp\Tus\Server;
 use Symfony\Component\HttpFoundation\Request as HttpRequest;
 
 class Request
@@ -155,7 +156,7 @@ public function extractMeta(string $requestedKey) : string
      */
     public function extractPartials() : array
     {
-        return $this->extractFromHeader('Upload-Concat', 'final;');
+        return $this->extractFromHeader('Upload-Concat', Server::UPLOAD_TYPE_FINAL . ';');
     }
 
     /**
@@ -165,7 +166,7 @@ public function extractPartials() : array
      */
     public function isPartial() : bool
     {
-        return $this->header('Upload-Concat') === 'partial';
+        return Server::UPLOAD_TYPE_PARTIAL === $this->header('Upload-Concat');
     }
 
     /**
@@ -175,7 +176,7 @@ public function isPartial() : bool
      */
     public function isFinal() : bool
     {
-        return false !== strpos($this->header('Upload-Concat'), 'final;');
+        return false !== strpos($this->header('Upload-Concat'), Server::UPLOAD_TYPE_FINAL . ';');
     }
 
     /**