Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File object missing checksum and key on concat #120

Closed
fidelix opened this issue Jan 5, 2019 · 1 comment
Closed

File object missing checksum and key on concat #120

fidelix opened this issue Jan 5, 2019 · 1 comment
Labels
defect server Tus Server
Milestone
v1.0.4

Comments

@fidelix
Copy link
Contributor

fidelix commented Jan 5, 2019 •
edited
Loading

Describe the bug
The File object being inserted into the tus-server.upload.merged event is missing the upload key and the checksum.

They are defined but are never put back into the $file object:

tus-php/src/Tus/Server.php

Line 422 in 91f2f92

$checksum = $this->getServerChecksum($filePath);

To Reproduce

  1. Add a listener to the tus-server.upload.merged event;
  2. Inspect $file->details() or attempt to $file->getChecksum();
  3. key and checksum are missing;

Expected behavior
The checksum and uploadKey need to be available on the merged event.
fidelix added a commit to fidelix/tus-php that referenced this issue Jan 5, 2019
@fidelix
ankitpokhrel#120 - Added key and checksum to some events
eeb925d 
Issue ankitpokhrel#120.
UploadMerged and UploadCreated events were missing either one or both of key and checksum.
@fidelix fidelix mentioned this issue Jan 5, 2019
Merged
fidelix added a commit to fidelix/tus-php that referenced this issue Jan 5, 2019
@fidelix
Fixed tests for ankitpokhrel#120
6bea376
fidelix added a commit to fidelix/tus-php that referenced this issue Jan 5, 2019
@fidelix
ankitpokhrel#120 - Further fixes to the tests
ebd4c9a
ankitpokhrel pushed a commit that referenced this issue Jan 6, 2019
@fidelix @ankitpokhrel
#120 - Added key and checksum to some events (#122)
b339abb
@ankitpokhrel ankitpokhrel added defect server Tus Server and removed need to check labels Jan 6, 2019
@ankitpokhrel
Copy link
Owner

Fixed in #122

@ankitpokhrel ankitpokhrel added this to the Unreleased milestone Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect server Tus Server
Projects
None yet
Milestone
v1.0.4
Development

No branches or pull requests
2 participants
@fidelix @ankitpokhrel