Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a public setChecksum method for Client #121

Closed
fidelix opened this issue Jan 5, 2019 · 1 comment
Closed

Create a public setChecksum method for Client #121

fidelix opened this issue Jan 5, 2019 · 1 comment
Labels
client Tus Client improvement
Milestone
v1.0.4

Comments

@fidelix
Copy link
Contributor

fidelix commented Jan 5, 2019 •
edited
Loading

I have pre-calculated hashes for my files and the Tus Client needs to calculate the hash again (or one needs to monkey-patch the Client class with a setChecksum method) for every file.

Monkey-patching is ugly, and unnecessary in this case as it's a method that would very much make sense to have on the Client.
@fidelix fidelix changed the title Create a public setChecksum method Create a public setChecksum method for Client Jan 5, 2019
fidelix added a commit to fidelix/tus-php that referenced this issue Jan 5, 2019
@fidelix
ankitpokhrel#121 - Added public setCheckSum method to Client
51a22c7
ankitpokhrel pushed a commit that referenced this issue Jan 5, 2019
@fidelix @ankitpokhrel
#121 - Added public setCheckSum method to Client (#123)
be841b2
@ankitpokhrel
Copy link
Owner

See #123

@ankitpokhrel ankitpokhrel added this to the Unreleased milestone Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client Tus Client improvement
Projects
None yet
Milestone
v1.0.4
Development

No branches or pull requests
2 participants
@fidelix @ankitpokhrel