Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing checks in patch request #96

Closed
ankitpokhrel opened this issue Oct 23, 2018 · 1 comment
Closed

Add missing checks in patch request #96

ankitpokhrel opened this issue Oct 23, 2018 · 1 comment
Labels
defect good first issue server Tus Server
Projects
Kanban
Milestone
v0.1.0

Comments

@ankitpokhrel
Copy link
Owner

ankitpokhrel commented Oct 23, 2018 •
edited
Loading

Some checks are missing in patch request

  • All PATCH requests MUST use Content-Type: application/offset+octet-stream, otherwise the server SHOULD return a 415 Unsupported Media Type status.

  • Invalid now If a PATCH request does not include a Content-Length header containing an integer value larger than 0, the server SHOULD return a 400 Bad Request status.

Link to Tus Protocol Documentation on PATCH
@ankitpokhrel ankitpokhrel added this to the Unreleased milestone Oct 23, 2018
@ankitpokhrel ankitpokhrel added this to To Do in Kanban Oct 23, 2018
DrudgeRajen added a commit to DrudgeRajen/tus-php that referenced this issue Oct 23, 2018
@DrudgeRajen
Merge branch 'master' into issue-fix/ankitpokhrel#96
ca75b1b
@ankitpokhrel ankitpokhrel moved this from To Do to In progress in Kanban Oct 24, 2018
DrudgeRajen added a commit to DrudgeRajen/tus-php that referenced this issue Oct 24, 2018
@DrudgeRajen
Merge branch 'master' into issue-fix/ankitpokhrel#96
4887b3c
@ankitpokhrel
Copy link
Owner Author

Fixed in #98

Kanban automation moved this from In progress to Done Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect good first issue server Tus Server
Projects
No open projects
Kanban
  
Done
Milestone
v0.1.0
Development

No branches or pull requests
1 participant
@ankitpokhrel