-
Notifications
You must be signed in to change notification settings - Fork 31
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Skip esvalid errors about unsupported node types
Esvalid https://github.com/estools/esvalid hasn't been updated for a while, so it doesn't recognise newer JS standards' node types as valid at all. Rather than skip error checking altogether, I decided to just create a list of all the node types esvalid supports, and ignore errors relating to types other than those. This way, we retain sanity checks for stuff like variable names containing property access { type: "Identifier", name: "a.b" } and other such insanity, which escodegen doesn't throw errors for for performance reasons, but which are very likely to be user error. Ideally in the long term we should patch esvalid to check new node types for sanity also.
- Loading branch information
Showing
2 changed files
with
36 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters