Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging in latest version of gcp #4

Merged
merged 1 commit into from
Jun 27, 2017
Merged

Fix logging in latest version of gcp #4

merged 1 commit into from
Jun 27, 2017

Conversation

ankurcha
Copy link
Owner

As per
https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud/blob/master/lib/fluent/plugin/out_google_cloud.rb#L1175

If message is present in the payload it's interpreted as a textPayload which is not what we want, it should be named something else, this hack gets around this.

@ankurcha ankurcha self-assigned this Jun 27, 2017
@ankurcha ankurcha merged commit 8fc31c2 into master Jun 27, 2017
@plelevier
Copy link

plelevier commented Jul 4, 2017

Hi ankurcha,

First, thanks for your work!

Why did you rollback this change in 1.1.6?

I've not tested yet 1.1.5 but after upgrading from 1.1.3 to 1.1.6, I still get GKE logs interpreted as a textPayload (The problem is on a recently upgraded kubernetes cluster. The appender still works fine with our old cluster)

@plelevier
Copy link

Ok I found out myself this issue on the google side : kubernetes/kubernetes#48108

So it seems it will be fixed on the next kubernetes version, until then we should not be using kubernetes 1.6.6 and stay with 1.6.4 (as described here : https://cloud.google.com/container-engine/release-notes )

@ankurcha ankurcha deleted the gcp-2.0-compat branch April 6, 2018 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants