Add custom attributes to log messages #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xperimental
force-pushed
the
custom-attributes
branch
2 times, most recently
from
64e381c
to
97e0d49
Compare
xperimental
force-pushed
the
custom-attributes
branch
from
97e0d49
to
393e920
Compare
|
Any opinion on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From looking at the current implementation it looks to me like there is no way of attaching arbitrary information to a log message aside from using the MDC, which groups all the information under
detailsand also looks like it only works properly if a single request is not multiplexed across multiple threads.This pull-request provides a simple implementation for attaching custom information to a log entry.