Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: korean, format string #136

Merged
merged 3 commits into from Dec 5, 2020
Merged

Conversation

tlatkdgus1
Copy link
Contributor

@tlatkdgus1 tlatkdgus1 commented Dec 3, 2020

  1. Add korean in translate.json
  2. Format string support for natural sentence writing

result

locale example

Issue

#23

Copy link
Owner

@anmol098 anmol098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tlatkdgus1
LGTM;
Thank you for improving the translation
Natural sentence writing is a good added feature

@anmol098 anmol098 merged commit d73f18b into anmol098:master Dec 5, 2020
anmol098 added a commit that referenced this pull request Dec 5, 2020
anmol098 added a commit that referenced this pull request Dec 5, 2020
@anmol098 anmol098 mentioned this pull request Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants