Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plural/Singular Wording for GitHub data section #34

Merged
merged 1 commit into from Aug 3, 2020
Merged

Plural/Singular Wording for GitHub data section #34

merged 1 commit into from Aug 3, 2020

Conversation

hedyhli
Copy link
Contributor

@hedyhli hedyhli commented Aug 3, 2020

I've actually just tried this action a few minutes ago, and I think it's really cool. But for the ”My Github data’ section:
8F0BF9D8-F2AA-4E9C-977D-2FF7C0804C54

The wording with more than 1 repository is a bit weird, and would be better if it was ”repositories”, so I updated the code so that when it's >1 the word would be plural, if not, singular

“repository” for 1
“repositories” for >1

A064C387-26FA-4FF3-B62B-E363FBB8BDA0

I have not tested the changes as a GitHub action because I think it’s a really small change, but I did tested the parts I changed with a python interpreter.

Super sorry because I know I have a bad commit message

“repository” for 1
“repositories” for >1
@hedyhli hedyhli changed the base branch from master to Alpha August 3, 2020 02:12
@hedyhli hedyhli changed the base branch from Alpha to master August 3, 2020 03:21
@anmol098 anmol098 merged commit 3e28fb3 into anmol098:master Aug 3, 2020
@hedyhli hedyhli deleted the patch-1 branch August 3, 2020 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants