Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenSSL: select protocol during server ALPN #20

Merged
merged 1 commit into from
Apr 28, 2021
Merged

OpenSSL: select protocol during server ALPN #20

merged 1 commit into from
Apr 28, 2021

Conversation

aantron
Copy link
Contributor

@aantron aantron commented Apr 28, 2021

Before this commit, the server does not actually select a protocol during ALPN. The code in this commit is from h2's ALPN example:

I've been running this code for about 1.5 months. Seems to work fine.

anmonteiro
anmonteiro approved these changes Apr 28, 2021
View reviewed changes
Copy link
Owner

@anmonteiro anmonteiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, thanks!

@aantron aantron mentioned this pull request Apr 28, 2021
Merged
@anmonteiro anmonteiro merged commit 4ea6db1 into anmonteiro:master Apr 28, 2021
anmonteiro added a commit that referenced this pull request May 19, 2021
@anmonteiro
changes for #20 and #21
039a3b7
@aantron aantron deleted the alpn-select-protocol branch December 1, 2021 11:54
@anmonteiro anmonteiro mentioned this pull request Aug 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmonteiro anmonteiro anmonteiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aantron @anmonteiro