New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lwt,eio: remove Client.socket #75

Merged

anmonteiro merged 1 commit into master from anmonteiro/rm-gluten-eio-client-socket

Apr 20, 2024

Owner

anmonteiro commented Apr 19, 2024

suggested by @wokalski


          lwt,eio: remove Client.socket

8e4acb2

wokalski commented Apr 20, 2024

makes sense imo as it was passed from the outside anyway so presumably the caller has access to it and can manage it itself.

anmonteiro merged commit 260fced into master

3 checks passed

anmonteiro deleted the anmonteiro/rm-gluten-eio-client-socket branch

April 20, 2024 04:23

wokalski mentioned this pull request

Don't require Unix in order to use mock sockets #74

Merged

anmonteiro added a commit that referenced this pull request


          add changelog for #74 and #75

c4e5085

anmonteiro added a commit to anmonteiro/opam-repository that referenced this pull request


          [new release] gluten (6 packages) (0.5.1)

1f4cd1a

CHANGES:

- gluten-lwt,gluten-eio: remove `Client.socket`
  ([anmonteiro/gluten#75](anmonteiro/gluten#75))
- gluten-eio: don't require `Eio_unix.stream_socket_ty`, allowing the use of
  mock sockets ([anmonteiro/gluten#74](anmonteiro/gluten#74))

anmonteiro mentioned this pull request

[new release] gluten (6 packages) (0.5.1) ocaml/opam-repository#26018

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment