binding treated as serial

[mfikes]

There is a bit of code here that binds env/*compiler* to st and then uses env/*compiler* on the subsequent line.

lumo/src/cljs/snapshot/lumo/repl.cljs

Lines 946 to 947 in 658732f

	env/*compiler* st
	r/*data-readers* (merge tags/*cljs-data-readers* (load-data-readers! env/*compiler*))

Binding is actually supposed to be done in parallel (see https://dev.clojure.org/jira/browse/CLJS-2541) so to make the above code correct would simply involve not making use of env/*compiler* in that subsequent line, but using st.

There is a similar pattern involving env/*compiler* and st later on in the file.

[anmonteiro]

Have you fixed this in Planck? Is there a commit I can steal? :)

[mfikes]

I think I noticed this when stealing code from Lumo to do planck-repl/planck@5b45533 but I don't recall why Planck didn't end up with the same code.

[mfikes]

But, I think the fix is simply revising the referenced code from

  env/*compiler* st 
  r/*data-readers* (merge tags/*cljs-data-readers* (load-data-readers! env/*compiler*)) 

to

  env/*compiler* st 
  r/*data-readers* (merge tags/*cljs-data-readers* (load-data-readers! st))