Finish client stream after trailer headers #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
approved these changes
Feb 18, 2022
anmonteiro
added a commit
that referenced
this pull request
Feb 18, 2022
anmonteiro
added a commit
that referenced
this pull request
Feb 18, 2022
ansiwen
pushed a commit
to ansiwen/ocaml-h2
that referenced
this pull request
May 2, 2022
anmonteiro
added a commit
to anmonteiro/opam-repository
that referenced
this pull request
Aug 15, 2022
…(0.9.0) CHANGES: - h2: Fix tests on 32-bit platforms ([anmonteiro/ocaml-h2#152](anmonteiro/ocaml-h2#152)) - h2-mirage: adapt to Conduit v4 and remove `H2_mirage.Server_with_conduit` ([anmonteiro/ocaml-h2#154](anmonteiro/ocaml-h2#154)) - h2: fix memory leaks related to trailer headers in the server and client implementations ([anmonteiro/ocaml-h2#159](anmonteiro/ocaml-h2#159) (thanks [@quernd](https://github.com/quernd)!), [anmonteiro/ocaml-h2#160](anmonteiro/ocaml-h2#160)) - h2: allow configuring `flush_headers_immediately` on the client and default to `false`. This means that h2 will wait for the first request body bytes to be scheduled and batch `HEADERS` and `DATA` frames when sending requests ([anmonteiro/ocaml-h2#163](anmonteiro/ocaml-h2#163), [anmonteiro/ocaml-h2#164](anmonteiro/ocaml-h2#164)) - h2: Split `Body.t` into `Body.Writer.t` and `Body.Reader.t` ([anmonteiro/ocaml-h2#165](anmonteiro/ocaml-h2#165)) - h2: OCaml 5.00 compatibility -- add `seeded_hash` to `scheduler.ml` ([anmonteiro/ocaml-h2#168](anmonteiro/ocaml-h2#168)) - h2: Use a tail-recursive version of `Angstrom.skip_many`. Fixes a memory leak in long-running connections e.g. gRPC ([anmonteiro/ocaml-h2#172](anmonteiro/ocaml-h2#172)) - h2-async: Add an OCaml-TLS client to `h2-async` ([anmonteiro/ocaml-h2#174](anmonteiro/ocaml-h2#174)) - h2: Fix a bug that caused different requests to share the same headers buffer under concurrency ([anmonteiro/ocaml-h2#182](anmonteiro/ocaml-h2#182))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a memory leak which occurs in the following setting:
The memory is only freed when the connection is closed.
It seems to come down to the client streams not being "finished" after receiving trailing headers.
I benchmarked with
Memtraceand with this change, memory consumption is now stable.