Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft changes #1

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Draft changes #1

wants to merge 7 commits into from

Conversation

anmyachev
Copy link
Owner

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves #?
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
PERF-#0000: draft changes
d076567 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
fix
9f07a48 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
changes for reset_index
c1fbdc6 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
fixes
236ce44 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
fixes
3ca5435 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
change groupby
a524593 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
rank changes
a69effa 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 3, 2023
View reviewed changes
modin/pandas/series.py
if not self._query_compiler.lazy_execution:
obj = self.copy()
obj.name = name
from .dataframe import DataFrame

Check notice

Code scanning / CodeQL

Cyclic import Note

Import of module
modin.pandas.dataframe
Loading
begins an import cycle.
modin/pandas/series.py
if drop:
return self.__constructor__(query_compiler=new_query_compiler)
else:
from .dataframe import DataFrame

Check notice

Code scanning / CodeQL

Cyclic import Note

Import of module
modin.pandas.dataframe
Loading
begins an import cycle.
modin/core/dataframe/pandas/dataframe/dataframe.py
Comment on lines +731 to +732
# if axis == 0:
# breakpoint()

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@anmyachev