Ignore unknown fields for marshmallow2 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaceorc
approved these changes
Dec 1, 2022
foobarbazmeow
approved these changes
Dec 1, 2022
AStepanov
reviewed
Dec 1, 2022
| @@ -163,6 +163,13 @@ def post_load(self, data: dict[str, Any]) -> Any: | |||
|
|
|||
| @m.pre_load # type: ignore | |||
| def pre_load(self, data: dict[str, Any]) -> Any: | |||
There was a problem hiding this comment.
May be it could be optional (maybe with turn on by default), with an exception for overlap names? This way it might be more useful for general porpoise
AStepanov
reviewed
Dec 1, 2022
| @@ -163,6 +163,13 @@ def post_load(self, data: dict[str, Any]) -> Any: | |||
|
|
|||
| @m.pre_load # type: ignore | |||
| def pre_load(self, data: dict[str, Any]) -> Any: | |||
| # Exclude unknown fields | |||
There was a problem hiding this comment.
Suggested change
| # Exclude unknown fields | |
| # Exclude unknown fields to prevent possible value overriding in marshmallow 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works correctly for marshmallow3, but doesn't for marshmallow2