Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Angular 9 support #32

Closed
bsautel opened this issue Mar 25, 2020 · 2 comments
Closed

Add Angular 9 support #32

bsautel opened this issue Mar 25, 2020 · 2 comments

Comments

@bsautel
Copy link

bsautel commented Mar 25, 2020

Does not work with Angular 9:

Compiling ng2-go-top-button : main as commonjs
ERROR in getInternalNameOfClass() called on a non-ES5 class: expected GoTopButton to have an inner class declaration

Would it be compatible to make a new version compatible with Angular 9?

Thanks a lot!

@bsautel
Copy link
Author

bsautel commented Mar 26, 2020

I created pull request #33 that adds Angular 9 support.

@annapogorelova could you have a look at it please?

@annapogorelova
Copy link
Owner

Hi, @bsautel, sorry for the late reply and thank you for your work. I have created a new NPM package ng-go-top-button which corresponds to the new Angular library format and supports Angular 9.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants