Skip to content

Commit

Permalink
fix: fix modal and drawer component missing uid
Browse files Browse the repository at this point in the history
  • Loading branch information
anncwb committed Dec 12, 2020
1 parent f7ec3c9 commit 1293a73
Show file tree
Hide file tree
Showing 7 changed files with 14 additions and 8 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.zh_CN.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
- 修复 axios 大小写问题
- 修复按钮样式问题
- 修复菜单分割模式问题
- 修复 `Modal``Drawer`组件在使用 emits 数据传递失效问题

## 2.0.0-rc.13 (2020-12-10)

Expand Down
4 changes: 3 additions & 1 deletion src/components/Application/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { withInstall } from '../util';
import { createAsyncComponent } from '/@/utils/factory/createAsyncComponent';
import AppLogo from './src/AppLogo.vue';

export const AppLocalePicker = createAsyncComponent(() => import('./src/AppLocalePicker.vue'), {
loading: true,
Expand All @@ -8,8 +9,9 @@ export const AppProvider = createAsyncComponent(() => import('./src/AppProvider.
export const AppSearch = createAsyncComponent(() => import('./src/search/AppSearch.vue'), {
loading: true,
});
export const AppLogo = createAsyncComponent(() => import('./src/AppLogo.vue'));
// export const AppLogo = createAsyncComponent(() => import('./src/AppLogo.vue'));

withInstall(AppLocalePicker, AppLogo, AppProvider, AppSearch);

export { useAppProviderContext } from './src/useAppContext';
export { AppLogo };
2 changes: 1 addition & 1 deletion src/components/Drawer/src/useDrawer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export const useDrawerInner = (callbackFn?: Fn): UseDrawerInnerReturnType => {

uidRef.value = uuid;
drawerInstanceRef.value = modalInstance;
currentInstall.emit('register', modalInstance);
currentInstall.emit('register', modalInstance, uuid);
};

watchEffect(() => {
Expand Down
6 changes: 4 additions & 2 deletions src/components/Modal/src/useModal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,9 @@ export const useModalInner = (callbackFn?: Fn): UseModalInnerReturnType => {
throw new Error('instance is undefined!');
}

// currentInstall.type.emits = [...currentInstall.type.emits, 'register'];
// Object.assign(currentInstall.type.emits, ['register']);

const getInstance = () => {
const instance = unref(modalInstanceRef);
if (!instance) {
Expand All @@ -103,10 +106,9 @@ export const useModalInner = (callbackFn?: Fn): UseModalInnerReturnType => {
tryOnUnmounted(() => {
modalInstanceRef.value = null;
});

uidRef.value = uuid;
modalInstanceRef.value = modalInstance;
currentInstall.emit('register', modalInstance);
currentInstall.emit('register', modalInstance, uuid);
};

watchEffect(() => {
Expand Down
5 changes: 3 additions & 2 deletions src/layouts/default/header/LayoutMultipleHeader.less
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
.multiple-tab-header {
flex: 0 0 auto;
margin-left: 1px;
transition: width 0.2s;
flex: 0 0 auto;

&.dark {
margin-left: -1px;
margin-left: 0;
}

&.fixed {
Expand Down
2 changes: 1 addition & 1 deletion src/layouts/default/index.less
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@
}

&__main {
margin-left: 2px;
margin-left: 1px;
}
}
2 changes: 1 addition & 1 deletion src/layouts/default/sider/index.less
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
}

&:not(.ant-layout-sider-dark) {
box-shadow: 2px 0 8px 0 rgba(29, 35, 41, 0.05);
// box-shadow: 2px 0 8px 0 rgba(29, 35, 41, 0.05);

.ant-layout-sider-trigger {
color: @text-color-base;
Expand Down

0 comments on commit 1293a73

Please sign in to comment.