Skip to content
This repository has been archived by the owner on Jan 13, 2021. It is now read-only.

Inline IDLDefined #20

Closed
annevk opened this issue Jan 19, 2016 · 5 comments
Closed

Inline IDLDefined #20

annevk opened this issue Jan 19, 2016 · 5 comments

Comments

@annevk
Copy link
Owner

annevk commented Jan 19, 2016

In https://www.w3.org/Bugs/Public/show_bug.cgi?id=29376 we concluded that this would be better defined here as only Location needs it. What exactly it needs to say is still a little bit unclear as noted there, I hope @bholley or @bzbarsky can weigh in on that.

As @bzbarsky noted it would be best not to align this fully with WindowProxy's handling of [[Configurable]] as that would less likely be web-compatible.

@bzbarsky
Copy link
Collaborator

I think it would be fine to just talk about properties defined by the IDL Location interface or its consequential interfaces, and leave it at that. An informative note could point out that this includes toJSON and valueOf and whatnot.

@annevk
Copy link
Owner Author

annevk commented Jan 27, 2016

I think that might end up being confusing. E.g., when IDL itself talks about members of of interfaces or consequential interfaces that excludes the members that will be added as part of IDL syntax, such as an iterable declaration adding "entries".

@annevk
Copy link
Owner Author

annevk commented Jan 29, 2016

I think the way to define this is by simply putting all the properties that are IDL-defined in a slot after the object is allocated. That way this and #22 can be defined in one simple sweep.

@annevk
Copy link
Owner Author

annevk commented Jan 29, 2016

@bzbarsky @heycam do you know which internal methods IDL needs when it initializes an object? I have DefineOwnProperty and OwnPropertyKeys (for my own purposes) thus far.

annevk added a commit that referenced this issue Jan 29, 2016
This addresses #20 partially. We still need to know what internal
methods IDL uses and make sure we don’t override those until after we
allocated the object (through the standardDefinedProperties slot).

This fixes #19 by defining the properties listed through internal
methods rather than IDL directly after allocation. It also makes them
unenumerable (a change from IDL requested by @zcorpan).
@bzbarsky
Copy link
Collaborator

IDL doesn't really define the object initialization explicitly, but seems like it can all be done with DefineOwnProperty only.

@annevk annevk closed this as completed in 5de6f79 Jan 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants