Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParseError with macros using leading underscore #27

Closed
Deynix opened this issue Aug 30, 2022 · 1 comment
Closed

ParseError with macros using leading underscore #27

Deynix opened this issue Aug 30, 2022 · 1 comment

Comments

@Deynix
Copy link

Deynix commented Aug 30, 2022

To help keep my macro menu uncluttered I have leading underscores on a lot of my macros including the start/end macros (_START_PRINT and _END_PRINT). When attempting to use klipper_estimator it throws an error if these macros are used:

thread 'main' panicked at 'gcode read: ParseError(GCodeParseError { position: "_START_PRINT BED_TEMP=70 EXTRUDER_TEMP=215" })', tool\src\cmd\estimate.rs:202:27

If I remove the leading underscores and just call them "START_PRINT" and "END_PRINT", the parse runs correctly.

Using a freshly-built copy of klipper_estimator 2.0.4 on Windows 10; slicer is SuperSlicer 2.5.59.0.

@dalegaard
Copy link
Collaborator

Hi @Deynix

This is now fixed in commit 8997799, released as v2.0.5.

Thanks for reporting!

Best regards,
Lasse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants