forked from AdguardTeam/AdGuardHome
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Squashed commit of the following: commit 1f7be03 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Thu Mar 21 13:35:37 2024 +0300 all: use standard md style in some docs
- Loading branch information
Showing
3 changed files
with
53 additions
and
99 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,89 +1,57 @@ | ||
| # Contributing to AdGuard Home | ||
| # Contributing to AdGuard Home | ||
|
|
||
| If you want to contribute to AdGuard Home by filing or commenting on an issue or | ||
| opening a pull request, please follow the instructions below. | ||
| If you want to contribute to AdGuard Home by filing or commenting on an issue or opening a pull request, please follow the instructions below. | ||
|
|
||
| ## General recommendations | ||
|
|
||
| Please don’t: | ||
|
|
||
| ## General recommendations | ||
| - post comments like “+1” or “this”. Use the :+1: reaction on the issue instead, as this allows us to actually see the level of support for issues. | ||
|
|
||
| Please don't: | ||
| - file issues about localization errors or send localization updates as PRs. We’re using [CrowdIn] to manage our translations and we generally update them before each Beta and Release build. You can learn more about translating AdGuard products [in our Knowledge Base][kb-trans]. | ||
|
|
||
| * post comments like “+1” or “this”. Use the :+1: reaction on the issue | ||
| instead, as this allows us to actually see the level of support for issues. | ||
| - file issues about a particular filtering-rule list misbehaving. These are tracked through the [separate form for filtering issues][form]. | ||
|
|
||
| * file issues about localization errors or send localization updates as PRs. | ||
| We're using [CrowdIn] to manage our translations and we generally update | ||
| them before each Beta and Release build. You can learn more about | ||
| translating AdGuard products [in our Knowledge Base][kb-trans]. | ||
|
|
||
| * file issues about a particular filtering-rule list misbehaving. These are | ||
| tracked through the [separate form for filtering issues][form]. | ||
|
|
||
| * send updates to filtering-rule lists, such as the ones for the Blocked | ||
| Services feature or the list of approved filtering-rule lists. We update | ||
| them once before each Beta and Release build. | ||
| - send or request updates to filtering-rule lists, such as the ones for the Blocked Services feature or the list of approved filtering-rule lists. We update them from the [separate repository][hostlist] once before each Beta and Release build. | ||
|
|
||
| Please do: | ||
|
|
||
| * follow the template instructions and provide data for reproducing issues. | ||
| - follow the template instructions and provide data for reproducing issues. | ||
|
|
||
| * write the title of your issue or pull request in English. Any language is | ||
| fine in the body, but it is important to keep the title in English to make | ||
| it easier for people and bots to look up duplicated issues. | ||
| - write the title of your issue or pull request in English. Any language is fine in the body, but it is important to keep the title in English to make it easier for people and bots to look up duplicated issues. | ||
|
|
||
| [CrowdIn]: https://crowdin.com/project/adguard-applications/en#/adguard-home | ||
| [form]: https://link.adtidy.org/forward.html?action=report&app=home&from=github | ||
| [hostlist]: https://github.com/AdguardTeam/HostlistsRegistry | ||
| [kb-trans]: https://kb.adguard.com/en/general/adguard-translations | ||
|
|
||
| ## Issues | ||
|
|
||
| ### Search first | ||
|
|
||
| ## Issues | ||
|
|
||
| ### Search first | ||
|
|
||
| Please make sure that the issue is not a duplicate or a question. If it's a | ||
| duplicate, please react to the original issue with a thumbs up. If it's a | ||
| question, please look through our [Wiki] and, if you haven't found the answer, | ||
| post it to the GitHub [Discussions] page. | ||
| Please make sure that the issue is not a duplicate or a question. If it’s a duplicate, please react to the original issue with a thumbs up. If it’s a question, please look through our [Wiki] and, if you haven’t found the answer, post it to the GitHub [Discussions] page. | ||
|
|
||
| [Discussions]: https://github.com/AdguardTeam/AdGuardHome/discussions/categories/q-a | ||
| [Wiki]: https://github.com/AdguardTeam/AdGuardHome/wiki | ||
|
|
||
| ### Follow the issue template | ||
|
|
||
| Developers need to be able to reproduce the faulty behavior in order to fix an issue, so please make sure that you follow the instructions in the issue template carefully. | ||
|
|
||
| ### Follow the issue template | ||
|
|
||
| Developers need to be able to reproduce the faulty behavior in order to fix an | ||
| issue, so please make sure that you follow the instructions in the issue | ||
| template carefully. | ||
|
|
||
| ## Pull requests | ||
|
|
||
| ### Discuss your changes first | ||
|
|
||
| ## Pull requests | ||
| Please discuss your changes by opening an issue. The maintainers should evaluate your proposal, and it’s generally better if that’s done before any code is written. | ||
|
|
||
| ### Discuss your changes first | ||
| ### Review your changes for style | ||
|
|
||
| Please discuss your changes by opening an issue. The maintainers should | ||
| evaluate your proposal, and it's generally better if that's done before any code | ||
| is written. | ||
|
|
||
|
|
||
|
|
||
| ### Review your changes for style | ||
|
|
||
| We have a set of [code guidelines][hacking] that we expect the code to follow. | ||
| Please make sure you follow it. | ||
| We have a set of [code guidelines][hacking] that we expect the code to follow. Please make sure you follow it. | ||
|
|
||
| [hacking]: https://github.com/AdguardTeam/CodeGuidelines/blob/master/Go/Go.md | ||
|
|
||
| ### Test your changes | ||
|
|
||
| Make sure that it passes linters and tests by running the corresponding Make targets. For backend changes, it’s `make go-check`. For frontend, run `make js-lint`. | ||
|
|
||
| ### Test your changes | ||
|
|
||
| Make sure that it passes linters and tests by running the corresponding Make | ||
| targets. For backend changes, it's `make go-check`. For frontend, run | ||
| `make js-lint`. | ||
|
|
||
| Additionally, a manual test is often required. While we're constantly working | ||
| on improving our test suites, they're still not as good as we'd like them to be. | ||
| Additionally, a manual test is often required. While we’re constantly working on improving our test suites, they’re still not as good as we’d like them to be. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,13 @@ | ||
| # Security Policy | ||
| # Security Policy | ||
|
|
||
| ## Reporting a Vulnerability | ||
| ## Reporting vulnerabilities | ||
|
|
||
| Please send your vulnerability reports to <security@adguard.com>. To make sure | ||
| that your report reaches us, please: | ||
| Please send your vulnerability reports to <security@adguard.com>. To make sure that your report reaches us, please: | ||
|
|
||
| 1. Include the words “AdGuard Home” and “vulnerability” to the subject line as | ||
| well as a short description of the vulnerability. For example: | ||
| 1. Include the words “AdGuard Home” and “vulnerability” to the subject line as well as a short description of the vulnerability. For example: | ||
|
|
||
| > AdGuard Home API vulnerability: possible XSS attack | ||
| > AdGuard Home API vulnerability: possible XSS attack | ||
| 2. Make sure that the message body contains a clear description of the | ||
| vulnerability. | ||
| 2. Make sure that the message body contains a clear description of the vulnerability. | ||
|
|
||
| If you have not received a reply to your email within 7 days, please make sure | ||
| to follow up with us again at <security@adguard.com>. Once again, make sure | ||
| that the word “vulnerability” is in the subject line. | ||
| If you have not received a reply to your email within 7 days, please make sure to follow up with us again at <security@adguard.com>. Once again, make sure that the word “vulnerability” is in the subject line. |