dnsforward: imp tests

annguyen0 · Apr 15, 2024 · f1e4b72 · f1e4b72
1 parent 6ee6cc9
commit f1e4b72
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/internal/dnsforward/dnsforward_test.go b/internal/dnsforward/dnsforward_test.go
@@ -1668,6 +1668,7 @@ func TestServer_HandleBefore(t *testing.T) {
 		allowedClients    []string
 		disallowedClients []string
 		blockedHosts      []string
+		wantRCode         int
 	}{{
 		want:              assert.NotEmpty,
 		clientSrvName:     tlsServerName,
@@ -1676,6 +1677,7 @@ func TestServer_HandleBefore(t *testing.T) {
 		allowedClients:    []string{},
 		disallowedClients: []string{},
 		blockedHosts:      []string{},
+		wantRCode:         dns.RcodeSuccess,
 	}, {
 		want:              assert.NotEmpty,
 		clientSrvName:     clientID + "." + tlsServerName,
@@ -1684,6 +1686,7 @@ func TestServer_HandleBefore(t *testing.T) {
 		allowedClients:    []string{clientID},
 		disallowedClients: []string{},
 		blockedHosts:      []string{},
+		wantRCode:         dns.RcodeSuccess,
 	}, {
 		want:              assert.Empty,
 		clientSrvName:     "client-2." + tlsServerName,
@@ -1692,6 +1695,7 @@ func TestServer_HandleBefore(t *testing.T) {
 		allowedClients:    []string{clientID},
 		disallowedClients: []string{},
 		blockedHosts:      []string{},
+		wantRCode:         dns.RcodeRefused,
 	}, {
 		want:              assert.NotEmpty,
 		clientSrvName:     tlsServerName,
@@ -1700,6 +1704,7 @@ func TestServer_HandleBefore(t *testing.T) {
 		allowedClients:    []string{},
 		disallowedClients: []string{clientID},
 		blockedHosts:      []string{},
+		wantRCode:         dns.RcodeSuccess,
 	}, {
 		want:              assert.Empty,
 		clientSrvName:     clientID + "." + tlsServerName,
@@ -1708,6 +1713,7 @@ func TestServer_HandleBefore(t *testing.T) {
 		allowedClients:    []string{},
 		disallowedClients: []string{clientID},
 		blockedHosts:      []string{},
+		wantRCode:         dns.RcodeRefused,
 	}, {
 		want:              assert.NotEmpty,
 		clientSrvName:     tlsServerName,
@@ -1716,6 +1722,7 @@ func TestServer_HandleBefore(t *testing.T) {
 		allowedClients:    []string{},
 		disallowedClients: []string{},
 		blockedHosts:      []string{blockedHost},
+		wantRCode:         dns.RcodeSuccess,
 	}, {
 		want:              assert.Empty,
 		clientSrvName:     tlsServerName,
@@ -1724,10 +1731,13 @@ func TestServer_HandleBefore(t *testing.T) {
 		allowedClients:    []string{},
 		disallowedClients: []string{},
 		blockedHosts:      []string{blockedHost},
+		wantRCode:         dns.RcodeRefused,
 	}}
 
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {
+			t.Parallel()
+
 			s, _ := createTestTLS(t, TLSConfig{
 				TLSListenAddrs: []*net.TCPAddr{{}},
 				ServerName:     tlsServerName,
@@ -1738,7 +1748,7 @@ func TestServer_HandleBefore(t *testing.T) {
 			s.conf.BlockedHosts = tc.blockedHosts
 
 			err := s.Prepare(&s.conf)
-			require.NoErrorf(t, err, "failed to prepare server: %s", err)
+			require.NoError(t, err)
 
 			startDeferStop(t, s)
 
@@ -1758,6 +1768,7 @@ func TestServer_HandleBefore(t *testing.T) {
 			reply, _, err := client.Exchange(req, addr)
 			require.NoErrorf(t, err, "couldn't talk to server %s: %s", addr, err)
 			tc.want(t, reply.Answer)
+			assert.Equal(t, tc.wantRCode, reply.Rcode)
 		})
 	}
 }