Angular.jsからReactへ移行する #134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
December 14, 2014 03:55
added 7 commits
December 21, 2014 01:51
|
|
||
| _didChannelIdChange: -> | ||
| @currentChannelId != @newChannelId && | ||
| !(@currentChannelId == '' && @newChannelId == 'no_select') # 未選択状態で「ステータス」を選択してなかったら |
There was a problem hiding this comment.
Line exceeds maximum allowed length
| SpinnerStore.addChangeListener(@_onChange) | ||
|
|
||
| componentWillUnmount: -> | ||
| SpinnerStore.removeChangeListener(@_onChange); |
There was a problem hiding this comment.
Line contains a trailing semicolon
| `<div className='work-episodes container'> | ||
| <h2 className='text-center'>エピソード</h2> | ||
| <div className='multiple-checkin'> | ||
| <div className={switchButtonClass} onClick={this.startMultipleCheckinMode} onTouchStart={this.startMultipleCheckinMode}>一括チェックイン</div> |
There was a problem hiding this comment.
Line exceeds maximum allowed length
added 2 commits
January 3, 2015 22:55
Conflicts: app/controllers/checkins_controller.rb
| render: -> | ||
| props = @props | ||
|
|
||
| checkinPath = "/works/#{props.workId}/episodes/#{props.episodeId}/checkins/#{props.checkin.id}" |
There was a problem hiding this comment.
Line exceeds maximum allowed length
|
しばらくAngular.jsで良いや、という気持ちなりました。
このプルリクエストの中に副産物的に機能を改修した部分があるので、それをmasterブランチに取り込み、このプルリクエストは一旦破棄したいと思います。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
という条件でJSのライブラリ(フレームワーク)を探したところ、Reactが一番フィットした気がしたので、移行します。