Fix NoOverlapValidator #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix is on line 38 of lib/no_overlap_validator.rb The missing space between `record.isntance_eval` and `&options...` was causing an error when instance_eval was used. Also adds specs that act as a health check for the instance_scope feature.
oneamtu
reviewed
Apr 1, 2020
| class NoOverlapValidator < ActiveModel::Validator | ||
| def validate(record) | ||
| overlapping_records = temporally_overlapping_for(record) | ||
| instance_scope = if options[:instance_scope].is_a? Proc | ||
| record.instance_eval&options[:instance_scope] | ||
| record.instance_eval(&options[:instance_scope]) |
There was a problem hiding this comment.
Hm, yeah I thought I pointed out the typo in the other PR but I guess not; a victim of the line length crusade :)
It'll be important to release a new version. I'd even say we should yank out the old one but I doubt many people would notice.
There was a problem hiding this comment.
Yeah, this is a patch for sure
|
Octo approved via gchat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is on line 38 of
lib/no_overlap_validator.rbThe missing space between
record.isntance_evaland&options...was causing an error when instance_eval was used.Also adds specs that act as a health check for the instance_scope feature.