Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from max_exclusive to max_length (inclusive) #24

Merged
merged 3 commits into from Oct 12, 2022

Conversation

samuelcolvin
Copy link
Contributor

fix #23

Copy link
Contributor

@adriangb adriangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@codecov-commenter
Copy link

Codecov Report

Merging #24 (d50aa93) into main (9747ec3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #24   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           65        59    -6     
  Branches         5         5           
=========================================
- Hits            65        59    -6     
Impacted Files Coverage Δ
annotated_types/test_cases.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@samuelcolvin
Copy link
Contributor Author

Fixed some errors in the readme.

And now the coverage report comes through...3 hours to add a comment.

@samuelcolvin samuelcolvin merged commit cfe6ddf into main Oct 12, 2022
@samuelcolvin samuelcolvin deleted the max-inclusive branch October 12, 2022 10:44
adriangb pushed a commit to adriangb/annotated-types that referenced this pull request May 31, 2023
…pes#24)

* switch from max_exclusive to max_length (inclusive)

* tweak docstrings

* fix readme and another case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rethink max_exclusive, convert to max_inclusive?
4 participants