Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No point when ending polygon drawing #151

Closed
brianbourke75 opened this issue Jul 22, 2021 · 4 comments
Closed

No point when ending polygon drawing #151

brianbourke75 opened this issue Jul 22, 2021 · 4 comments
Labels
feature request New feature or request

Comments

@brianbourke75
Copy link

When one ends the drawing of a polygon with a double click a final point is placed at the point of the double click. Generally when I am drawing I am looking at the polygon as is and I don't think about the final point when I go to end. It would be a change in behavior where the double click is a simple acknowledgement of the completion of the polygon without that final point.

Again, this and the open seadragon tool are lovely and I thank you so much for making them!

@rsimon
Copy link
Member

rsimon commented Jul 23, 2021

I agree, that behavior would be better. (And/or another commonly seen pattern, where clicking the first point of the polygon again would close the shape. This is planned for #45.)

@brianbourke75
Copy link
Author

Great, thanks for the feedback!

@rsimon
Copy link
Member

rsimon commented Oct 27, 2021

I'm moving this issue over to the plugin repository. In the improved polygon selection tool I'm currently working, closing the shape will work by clicking the first point of the polygon again.

@rsimon
Copy link
Member

rsimon commented Oct 30, 2021

Update: the plan for the new polygon tool is that either of the following actions will close the polygon:

  1. hovering the mouse over/nearby the first point and clicking once (when hovering nearby, the cursor will snap over the first point)
  2. double click (anywhere) will close the polygon, without creating a new point, as you suggest above

Like the other issues, I'm closing this one in favour of the "todo-list" issue for the new polygon tool:

@rsimon rsimon closed this as completed Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants